Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache migration script #35810

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jan 21, 2025

This PR removes the "cache migration script" from src/transformers/utils/hub.py. No need to maintain it anymore IMO.

This script has been introduced in v4.22.0 (Sept. 2022) to move files from the old cache structure to the new one. Since it has now been 28 months, I think we can safely assume all caches have been moved by now. Worth case scenario, users will have to redownload their 2+ years old models if they update transformers.

I still kept a dummy deprecated move_cache method to avoid breaking imports. I can remove it if you think it's not necessary.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think this can safely be removed by now!

Not sure about keeping the deprecated move_cache method - I think it can probably be deleted, but it's not a big problem to leave it.

@Wauplin
Copy link
Contributor Author

Wauplin commented Jan 21, 2025

Not sure about keeping the deprecated move_cache method - I think it can probably be deleted, but it's not a big problem to leave it.

I'll let the transformers decide! I also think we should remove it but didn't want to introduce the breaking change myself 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants