Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_pipelines_video_classification that was always failing #35842

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CalOmnie
Copy link
Contributor

What does this PR do?

tests/test_pipelines_video_classification.py was always failing because the output of the video classifier, when run with one file path (as opposed to a list), is returning a list[dict] whereas the testing code was expecting a list[list[dict]], this PR corrects that assumption.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
It would be nice if someone could check that pytest tests/test_pipelines_video_classification.py actually fails for them too, it is possible that the issue comes from my environment

@Rocketknight1
Copy link
Member

cc @ydshieh, can you confirm this test was failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants