Nail in edge case of torch dtype being overriden permantly in the case of an error #35845
+70
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@BenjaminBossan and I have been trying to hunt down an issue causing some headache over the last few days, as to why some tests were failing if done in specific instances.
What we cornered it to, is if a user:
from_pretrained
or_from_config
), with adtype
other than the torch default dtypeWhat will occur is the torch dtype will permantly change, which is why some users may "discover" this issue and it goes away after a full restart (a likely scenario that could happen). What we currently do doesn't catch if we have an exception, this does, and is used as an additive
This PR introduces a safety decorator called
restore_default_torch_dtype
which will restore whatever torch's original dtype was prior to calling the function (since we restore it anyways at the end).This PR also adds a new
test_injection
function. The aim is for this function to be mocked at critical points where we need testing, and we cannot easily get to it (e.g. in this case, there was only one function we could mock infrom_pretrained
and zero functions we could mock in_from_config
to make sure this fix worked!)Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @BenjaminBossan @ArthurZucker