Github Actions update #34
Annotations
1 error and 10 warnings
build
Process completed with exit code 1.
|
build:
PriceChecker.Core/CommandHandlers/AgentsStoreWithOverwriteCommandHandler.cs#L38
Use "Async" suffix in names of methods that return an awaitable type (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD200.md)
|
build:
PriceChecker.Core/Services/PriceSeeker.cs#L53
Either log this exception and handle it, or rethrow it with some contextual information. (https://rules.sonarsource.com/csharp/RSPEC-2139)
|
build:
PriceChecker.Core.Tests/Repositories/ProductRepositoryTests.cs#L123
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|
build:
PriceChecker.Core.Tests/Repositories/ProductRepositoryTests.cs#L123
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
build:
PriceChecker.Core.Tests/Repositories/AgentRepositoryTests.cs#L10
Fix this implementation of 'IDisposable' to conform to the dispose pattern. (https://rules.sonarsource.com/csharp/RSPEC-3881)
|
build:
PriceChecker.Core.Tests/Repositories/AgentRepositoryTests.cs#L28
Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
|
build:
PriceChecker.Core.Tests/Repositories/ProductRepositoryTests.cs#L33
Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
|
build:
PriceChecker.Core.Tests/Repositories/ProductRepositoryTests.cs#L10
Type 'ProductRepositoryTests' owns disposable field(s) '_sut' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001)
|
build:
PriceChecker.UI/App.xaml.cs#L76
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|
build:
PriceChecker.UI/Views/TrackerProductViewModel.cs#L64
Complete the task associated to this 'TODO' comment. (https://rules.sonarsource.com/csharp/RSPEC-1135)
|