cache: fix pfree valueBuffer

hydradatabase · Dec 18, 2024 · fcc3292 · fcc3292
1 parent 063eb72
commit fcc3292
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/columnar/src/backend/columnar/columnar_reader.c b/columnar/src/backend/columnar/columnar_reader.c
@@ -1955,8 +1955,15 @@ DeserializeChunkData(StripeBuffers *stripeBuffers, uint64 chunkIndex,
 								  attributeForm->attlen, attributeForm->attalign,
 								  chunkData->valueArray[columnIndex]);
 
-			/* store current chunk's data buffer to be freed at next chunk read */
-			chunkData->valueBufferArray[columnIndex] = valueBuffer;
+			if(shouldCache)
+			{
+				/* store current chunk's data buffer to be freed at next chunk read */
+				chunkData->valueBufferArray[columnIndex] = NULL;
+			}
+			else
+			{
+				chunkData->valueBufferArray[columnIndex] = valueBuffer;
+			}
 		}
 		else if (columnAdded)
 		{