Fix percent-encoding of percent sign in grpc-message header

hyperium · Dec 25, 2024 · 40e4a1a · 40e4a1a
1 parent a8c1e39
commit 40e4a1a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/tonic/src/metadata/map.rs b/tonic/src/metadata/map.rs
@@ -2500,7 +2500,7 @@ mod tests {
     #[test]
     fn test_to_headers_encoding() {
         use crate::Status;
-        let special_char_message = "Beyond ascii \t\n\r🌶️💉💧🐮🍺";
+        let special_char_message = "Beyond 100% ascii \t\n\r🌶️💉💧🐮🍺";
         let s1 = Status::unknown(special_char_message);
 
         assert_eq!(s1.message(), special_char_message);
@@ -2509,6 +2509,17 @@ mod tests {
         let s2 = Status::from_header_map(&s1_map).unwrap();
 
         assert_eq!(s1.message(), s2.message());
+
+        assert!(
+            s1_map
+                .get("grpc-message")
+                .unwrap()
+                .to_str()
+                .unwrap()
+                .starts_with("Beyond%20100%25%20ascii"),
+            "Percent sign or other character isn't encoded as desired: {:?}",
+            s1_map.get("grpc-message")
+        );
     }
 
     #[test]

diff --git a/tonic/src/status.rs b/tonic/src/status.rs
@@ -14,6 +14,7 @@ const ENCODING_SET: &AsciiSet = &CONTROLS
     .add(b' ')
     .add(b'"')
     .add(b'#')
+    .add(b'%')
     .add(b'<')
     .add(b'>')
     .add(b'`')