feat(channel): Add local_address as an option Endpoint builder #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparris
force-pushed
the
jparris/local_address
branch
from
53f0039 to
9a59e0d
Compare
jparris
force-pushed
the
jparris/local_address
branch
2 times, most recently
from
556e3d5 to
4cb2f2a
Compare
jparris
force-pushed
the
jparris/local_address
branch
from
4cb2f2a to
65def4e
Compare
|
@tottoto can you take a look at this PR. |
tottoto
requested changes
Jan 16, 2025
tottoto
reviewed
Jan 16, 2025
Co-authored-by: tottoto <[email protected]>
jparris
force-pushed
the
jparris/local_address
branch
from
20b0714 to
4341f0d
Compare
tottoto
changed the title
tottoto
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I need to be able to set the local address of a Channel. This is the source IP address the Channel will be coming from. Currently Tonic's Channel builder doesn't expose a way to do this.
Solution
Add
local_addressto Endpoint builder.