Repair rust-analyzer for tonic files #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In my codebase I have files generated by prost and by tonic. I noticed that rust-analyzer was working fine with files generated by prost but not with files generated by tonic.
Solution
I found out that rust-analyzer doesn't like when a generated file is included with relative path. It only works with absolute path (i.g. when using the
OUT_DIRenv variable).I also found out that tonic always calls
prost_build::Config.out_dir, which causes prost to always generate includes with relative paths.My solution was to avoid setting the
out_dirin prost when unnecessary.