-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grpc-web proxy #359
Grpc-web proxy #359
Conversation
Reopening to continue leveraging CI. |
Hey! Thanks for opening this. I am currently on vacation and I want to think a bit about how we want to approach this. Will get back in a few weeks, sorry for the delay but this PR is quite big so want to make sure we do it right :) |
Hey! Sorry for the delay on this! I don't know much about the grpc-proxy stuff but would you be able to write up a bit on what is going no here? I want to aim for this to go into a 0.3 release but need to focus on a few important bug fixes before we get this in. |
Hi @LucioFranco I'll try to get a summary of where we're at done by tomorrow. |
Signed-off-by: John Hernandez <[email protected]>
It's not the intention that these changes are merged as is. In particular #[doc(hidden)] should be replaced by docs in each instance.
Hi @LucioFranco we're aiming to update tower examples. The plan is: (0) modernize the crate such that it builds The objective is to have an example tower http-client that builds against WASM as a step towards building a gRPC client in the browser. That is, our approach (which I think is consistent with your suggestion) is to specify a tower Service with a from-browser (over |
That sounds like a plan, I would also like to suggest that we do this in a separate crate in the workspace as well so that we can iterate on it without affecting the rest of the project. |
Do you mean move the examples crate |
Actually, I realized over the weekend that this approach is actually probably what we want! There are plans to extract the transport into its own crate but that is further down the line. As for the WASM compiling etc I have not done much testing there. Let me know what you need from me to get this merged! Thanks a ton for getting this going again 😄 |
How is it going ? |
Superseded by #455 |
Motivation
I'm interested in @john-hern 's tonic-based grpc-web bridge.
His PR: #288 has minor formatting issues
I ran
cargo fmt
to fix them. I'm opening this PR to check that the CI lint checks pass.