Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grpc-web proxy #359

Closed
wants to merge 10 commits into from
Closed

Grpc-web proxy #359

wants to merge 10 commits into from

Conversation

zancas
Copy link
Contributor

@zancas zancas commented May 20, 2020

Motivation

I'm interested in @john-hern 's tonic-based grpc-web bridge.
His PR: #288 has minor formatting issues
I ran cargo fmt to fix them. I'm opening this PR to check that the CI lint checks pass.

@zancas zancas changed the title Grpc proxy Grpc-web proxy May 31, 2020
@zancas zancas closed this May 31, 2020
@zancas
Copy link
Contributor Author

zancas commented Jun 1, 2020

Reopening to continue leveraging CI.

@zancas zancas reopened this Jun 1, 2020
@LucioFranco
Copy link
Member

Hey! Thanks for opening this. I am currently on vacation and I want to think a bit about how we want to approach this. Will get back in a few weeks, sorry for the delay but this PR is quite big so want to make sure we do it right :)

@LucioFranco
Copy link
Member

Hey! Sorry for the delay on this! I don't know much about the grpc-proxy stuff but would you be able to write up a bit on what is going no here? I want to aim for this to go into a 0.3 release but need to focus on a few important bug fixes before we get this in.

@zancas
Copy link
Contributor Author

zancas commented Jul 13, 2020

Hi @LucioFranco I'll try to get a summary of where we're at done by tomorrow.

@zancas
Copy link
Contributor Author

zancas commented Jul 16, 2020

Hi @LucioFranco we're aiming to update tower examples.

The plan is:

(0) modernize the crate such that it builds
(1 or 2) Then get the crate, or a feature gated subset, to build against WASM.
(2 or 1) Potentially build this PR against WASM.

The objective is to have an example tower http-client that builds against WASM as a step towards building a gRPC client in the browser.

That is, our approach (which I think is consistent with your suggestion) is to specify a tower Service with a from-browser (over fetch) transport. We want to establish that we can build some simpler examples of tower Service implementations against WASM.

@LucioFranco
Copy link
Member

That sounds like a plan, I would also like to suggest that we do this in a separate crate in the workspace as well so that we can iterate on it without affecting the rest of the project.

@zancas
Copy link
Contributor Author

zancas commented Jul 18, 2020

Do you mean move the examples crate https://github.com/tower-rs/examples into https://github.com/tower-rs/tower ? So it would be in the tower workspace adjacent to e.g. tower-layer, with a name like: tower-examples?

@LucioFranco
Copy link
Member

Actually, I realized over the weekend that this approach is actually probably what we want! There are plans to extract the transport into its own crate but that is further down the line.

As for the WASM compiling etc I have not done much testing there. Let me know what you need from me to get this merged! Thanks a ton for getting this going again 😄

@gustav3d
Copy link

How is it going ?

@LucioFranco
Copy link
Member

Superseded by #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants