-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: decode warp route information #176
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress but I suspect there are some issues still to fix
@@ -0,0 +1,95 @@ | |||
import Image from 'next/image'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you left these spaces in the imports? The empty lines prevent the prettier-plugin-organize-imports
from organizing the imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, also did this for files where I saw there are still spaces
|
||
return { | ||
amount: fromWei(parsedMessage.amount.toString(), originMetadata.nativeToken?.decimals || 18), | ||
totalPayment: fromWei(totalPayment, originMetadata.nativeToken?.decimals || 18), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're maybe misunderstanding what totalPayment refers to. It's a properly of the message relating to IGP gas. It's not related to warp transfer amounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed totalPayment and let GasDetailsCards
handle this
return { | ||
amount: fromWei(parsedMessage.amount.toString(), originMetadata.nativeToken?.decimals || 18), | ||
totalPayment: fromWei(totalPayment, originMetadata.nativeToken?.decimals || 18), | ||
endRecipient: address, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endRecipient: address, | |
recipient: address, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to transfer recipient
Leverage #144, to implement this:
Decodes warp route message to show more information about the warp token transfer
Fixes #78
ChainMap<Record<Address, TokenArgs>>;
, the last string would be the token symbolparseWarpRouteDetails()
function to decode the information about the warp transfer, a few checks are done to identify if the message is an actual warp route transferhyperlane
packages