Extend generic channel tests #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several problems with `func TestSetBackend`: - It looks like a test function but it is contained within a non-test package. - The test does not give any valuable information: We use it in the sim backend tests. However, the backend tests would fail anyways if the backend is not set correctly. Signed-off-by: Matthias Geihs <[email protected]>
Function `FromEthState` did not set the App correctly on a decoded state. Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
219-extend-generic-channel-tests
branch
from
169827e to
1513db6
Compare
Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
219-extend-generic-channel-tests
branch
from
1513db6 to
e682e05
Compare
Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
219-extend-generic-channel-tests
branch
from
dcd7d9f to
6de987a
Compare
Closed
ggwpez
reviewed
Sep 24, 2021
ggwpez
reviewed
Sep 24, 2021
| err := e.Timeout().Wait(ctx) | ||
| assert.NoError(t, err, "concluded: waiting") | ||
| } | ||
|
|
There was a problem hiding this comment.
I think the most important to test would be the event skipping and fast-forwarding of RegisteredEvents.
There was a problem hiding this comment.
Since the implementation is no trivial.
|
After some discussion, marking this as a draft. Planning to resume work on it later. |
|
Closed until this becomes a higher priority again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #219
Package channel: Adds generic tests for testing funder, adjudicator, and subscription implementation.