Revise generic wallet tests #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some discussion, we decided that revising the generic tests needs more work. We decided to resume work on it at a later point in time. |
Because the file is already in directory test, it does not need to include "test" in its name. Signed-off-by: Matthias Geihs <[email protected]>
…zer test There are several problems with `func TestSetBackend` and `func SetRandomizerTest`: - They look like a test function but they are contained within a non-test package. - They do not give any valuable information: We use them in the sim backend tests. However, the backend tests would fail anyways if not initialized correctly. Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
224-revise-generic-wallet-tests
branch
from
28754c9 to
0dbb06a
Compare
|
Update: Some changes from this PR (in particular the introduction of ZeroAddress on wallet test Setup) are needed for the upcoming backend implementations. |
We can use one test file per interface. Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
- Wallet should be provided with setup - UnlockedAccount was not provided an unlocked account, but calling Wallet.Unlock, which made it cumbersome to use. - Provide account address of wallet account instead of unlocked account Signed-off-by: Matthias Geihs <[email protected]>
…tAccountWithWalletAndBackend Naming schema: Include in name which interface types are tested. Signed-off-by: Matthias Geihs <[email protected]>
…ddress Naming schema: Include in name which interface type is tested. Signed-off-by: Matthias Geihs <[email protected]>
Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
224-revise-generic-wallet-tests
branch
from
0dbb06a to
767a1e3
Compare
Before, the wallet address test was generating a zero address assuming a specific address encoding. The assumption was that address encodings always have the same length and that decoding a zero bytes array of that length gives the zero address. However, while this was true for the existing backends, it may not be true for all future backends. Hence, we now provide the zero address specifically with the test setup. Signed-off-by: Matthias Geihs <[email protected]>
matthiasgeihs
force-pushed
the
224-revise-generic-wallet-tests
branch
from
767a1e3 to
2d44fd3
Compare
|
Github Actions seems to be not working correctly. The CI was not triggered after force push. Even a second force push (without changes) did not help. |
|
Close and reopen also did not trigger the CI. |
|
The GitHub Actions service is currently degraded: https://www.githubstatus.com I'll wait for the service to be up and running and will check back later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #224