Implement Funding component for IoT State Channels #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 22, 2023 19:28
- Use the following syntax consistently: 1. From<type> for funcs that convert from perun to protobuf types. 2. To<type> for funcs that convert from protobuf types to perun. Signed-off-by: Manoranjith <[email protected]>
- As these functions are closely coupled to protobuf bindings and do not implement any application logic, they fit better in "pb" package. - Also, move the tests on types in generated go bindings to "pb" package. Signed-off-by: Manoranjith <[email protected]>
- Include all methods defined by the Funder interface. - Also, update the command for generating protobufs. Signed-off-by: Manoranjith <[email protected]>
Signed-off-by: Manoranjith <[email protected]>
Signed-off-by: Manoranjith <[email protected]>
Signed-off-by: Manoranjith <[email protected]>
- Because the client initialization itself is not specific to ethereum blockchain or payments application. - Instead, the funder, adjudicator and wallet instances are passed as abstract interfaces and it is in the higher layer APIs, the functionality is limited to payments. Signed-off-by: Manoranjith <[email protected]>
- However, only local is supported now. - Also, add a nolint:funlen directive for session.New function. Signed-off-by: Manoranjith <[email protected]>
- Common types used across the perun-node project (including errors) are
defined in perun-node package.
- Hence, these definitions fit better in the perun package.
- Trigger for this change:
- to implement client side logic for grpc funder (in session package),
the grpc/pb package is needed, which creates an import cycle.
- because grpc/pb package imports payments package, which inturn
imports sessions package.
- and payment package is importing session package only for using the
error constants.
- hence moving these error constants breaks the import cycle by
removing the need for payments package to import sessions package.
Signed-off-by: Manoranjith <[email protected]>
Signed-off-by: Manoranjith <[email protected]>
Signed-off-by: Manoranjith <[email protected]>
Signed-off-by: Manoranjith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements funding component for IoT state channels.
Category
Implementation Task
Relevant issue
Closes #251
Testing
Tests for this component has not yet been added. It will be done after implementing #252 and #250.
Until then, all linter checks and existing tests should pass.
Steps to run the tests
Checklist