Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ipa-multipoint): switch to LE bytes #145

Merged

Conversation

dragan2234
Copy link
Contributor

@dragan2234 dragan2234 commented Jan 29, 2024

Switching to LE bytes paired with hyperledger/besu-verkle-trie#36 .

Closes #126

@dragan2234 dragan2234 force-pushed the ipa_multipoint-switch-to-le-bytes branch from e303b91 to f199dd1 Compare January 29, 2024 23:27
@dragan2234 dragan2234 marked this pull request as ready for review January 30, 2024 15:56
@dragan2234
Copy link
Contributor Author

I just realized that I forgot to reverse bytes in unit tests, and they are failing, reverting the PR to draft

@dragan2234 dragan2234 marked this pull request as draft January 31, 2024 03:20
Signed-off-by: Dragan Pilipovic <[email protected]>
@dragan2234 dragan2234 force-pushed the ipa_multipoint-switch-to-le-bytes branch from a3ba80c to 9e6d6cc Compare January 31, 2024 03:33
@dragan2234 dragan2234 marked this pull request as ready for review January 31, 2024 03:33
Copy link
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM approved just waiting for a small modification in the test

Signed-off-by: Dragan Pilipovic <[email protected]>
Copy link
Contributor

@matkt matkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matkt matkt merged commit 8ddd0df into hyperledger:main Feb 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communication between rust and Java should be in little-endian bytes
2 participants