-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ipa-multipoint): switch to LE bytes #145
chore(ipa-multipoint): switch to LE bytes #145
Conversation
e303b91
to
f199dd1
Compare
I just realized that I forgot to reverse bytes in unit tests, and they are failing, reverting the PR to draft |
Signed-off-by: Dragan Pilipovic <[email protected]>
Signed-off-by: Dragan Pilipovic <[email protected]>
a3ba80c
to
9e6d6cc
Compare
...ipoint/src/test/java/org/hyperledger/besu/nativelib/ipa_multipoint/LibIpaMultipointTest.java
Fixed
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM approved just waiting for a small modification in the test
...ipoint/src/test/java/org/hyperledger/besu/nativelib/ipa_multipoint/LibIpaMultipointTest.java
Fixed
Show resolved
Hide resolved
Signed-off-by: Dragan Pilipovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Switching to LE bytes paired with hyperledger/besu-verkle-trie#36 .
Closes #126