move trie key utils methods from besu to besu-verkle-trie #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim Taam <[email protected]>
|
lu-pinto
reviewed
Jan 23, 2025
| return Bytes32.wrap(CODE_OFFSET.add(UInt256.fromBytes(chunkId)).divide(VERKLE_NODE_WIDTH)); | ||
| } | ||
|
|
||
| public static List<Bytes32> getCodeChunkTrieKeyIndexes(final Bytes code) { |
There was a problem hiding this comment.
nit: getCodeChunkKeyTrieIndexes ?
To be consistent with other methods.
Or drop the Trie altogether from the methods because it's irrelevant since they are already inside a class called TrieKeyUtils
There was a problem hiding this comment.
modifed the name and used getCodeChunkKeyTrieIndexes
lu-pinto
reviewed
Jan 23, 2025
| } | ||
| } | ||
|
|
||
| public static List<Bytes32> getStorageKeyTrieIndexes(final List<Bytes32> storageSlotKeys) { |
There was a problem hiding this comment.
in Besu there was an Optional check to get the actual slotKey (Bytes32) out of a SlotStorageKeyobject, but I guess you'll handle that in Besu?
From Besu:
public List<Bytes32> generateStorageKeyIds(final Set<StorageSlotKey> storageSlotKeys) {
return storageSlotKeys.stream()
.map(
// --> storageSlotKey ->
// --> trieKeyAdapter.getStorageKeyTrieIndex(storageSlotKey.getSlotKey().orElseThrow()))
.map(Bytes32::wrap)
.toList();
}
There was a problem hiding this comment.
yes I will handle that in besu
Signed-off-by: Karim Taam <[email protected]>
Signed-off-by: Karim Taam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Another small cleaning by moving methods from Besu to Besu-verkle-trie
Fixed Issue(s)