fix: input validation

hyperledger · Dec 13, 2024 · bf7ffc1 · bf7ffc1
1 parent 6efb1f8
commit bf7ffc1
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/wasm/simple-tx/src/lib.rs b/wasm/simple-tx/src/lib.rs
@@ -61,9 +61,8 @@ impl InputExpr for CoinSelectionInput {
 fn send_ada(_: Config<()>, req: Params<TransferRequest>) -> WorkerResult<NewTx> {
     let mut tx = TxBuilder::new();
 
-    // TODO: return an error if this address is invalid
-    let from_address = Address::from_bech32(&req.from_address).unwrap();
-    let to_address = Address::from_bech32(&req.to_address).unwrap();
+    let from_address = Address::from_bech32(&req.from_address).map_err(|_| BuildError::MalformedAddress)?;
+    let to_address = Address::from_bech32(&req.to_address).map_err(|_| BuildError::MalformedAddress)?;
 
     let address_source = UtxoSource::Search(UtxoPattern {
         address: Some(AddressPattern {