Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devshell #1

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Add devshell #1

merged 4 commits into from
Oct 22, 2024

Conversation

gytis-ivaskevicius
Copy link
Contributor

@gytis-ivaskevicius gytis-ivaskevicius commented Oct 21, 2024

Context

Added devshell and treefmt

What does it do?

  • Devshell auto loads required tooling for the project, this includes:
    • treefmt - formatter
    • just - it is unused as of right now, but im sure that it will come in handy
    • rustc
    • cargo
    • rustfmt
    • clippy
  • treefmt is a simple executable that can wrap any formatter. Used to execute multiple formaters at the same time. As of right now, it supports Nix and Rust but we should consider adding formatters for yaml/markdown/etc

Testing

Tests were done by implementing CI job which validates devshell

@gytis-ivaskevicius gytis-ivaskevicius force-pushed the devshell branch 4 times, most recently from 006cc4e to f772bdc Compare October 21, 2024 13:07
Copy link

@michalrus michalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions:

README.md Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
.github/workflows/validate-devshell.yml Show resolved Hide resolved
Copy link

@michalrus michalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gytis-ivaskevicius gytis-ivaskevicius merged commit 3e4e01c into main Oct 22, 2024
5 checks passed
@gytis-ivaskevicius gytis-ivaskevicius deleted the devshell branch October 22, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants