chore(docker): add firefly-core #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,42 @@ | |||
| services: | |||
| firefly-core: | |||
| image: ghcr.io/gytis-ivaskevicius/firefly-core:latest | |||
There was a problem hiding this comment.
Are we okay with this? this was the easiest way to get image working in this repo
There was a problem hiding this comment.
@gytis-ivaskevicius will I be able to push updates to that image if necessary?
SupernaviX
reviewed
Jan 22, 2025
| namespaces: | ||
| default: default | ||
| predefined: | ||
| - defaultKey: addr_test1vqhkukz0285zvk0xrwk9jlq0075tx6furuzcjvzpnhtgelsuhhqc4 |
There was a problem hiding this comment.
Is there a way to inject this value from the ADDR_FROM environment variable?
There was a problem hiding this comment.
Probably. I was going through firefly helm chart and did not see any firefly config file, so probably it is configured via env variables. Is this a requirement or can we leave it is for time being?
There was a problem hiding this comment.
let's see if it causes issues in practice before spending too much time on it
SupernaviX
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding firefly-core to docker-compose. Does not run yet since I have no place to push modified firefly-core
Important Changes Introduced