Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no such volume error #308

Merged
merged 2 commits into from
Jun 18, 2024
Merged

fix: no such volume error #308

merged 2 commits into from
Jun 18, 2024

Conversation

EnriqueL8
Copy link
Contributor

Fixes #295

@EnriqueL8
fix: no such volume error
2ceb07f 
Signed-off-by: Enrique Lacal <[email protected]>
peterbroadhurst
peterbroadhurst approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion to consider before merging.

internal/stacks/stack_manager.go Outdated Show resolved Hide resolved
@EnriqueL8 @peterbroadhurst
Update internal/stacks/stack_manager.go
3448ca0 
Co-authored-by: Peter Broadhurst <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
@EnriqueL8 EnriqueL8 merged commit 1378d83 into main Jun 18, 2024
11 checks passed
@EnriqueL8 EnriqueL8 deleted the correct_volume_error branch June 18, 2024 10:27
@awrichar awrichar mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbroadhurst peterbroadhurst peterbroadhurst approved these changes

@awrichar awrichar Awaiting requested review from awrichar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Environment deletion fails with FF CLI built from main
2 participants
@EnriqueL8 @peterbroadhurst