Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Remove --platform flag from Docker commands in fabric_provider.go #323

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

dwertent
Copy link
Contributor

@dwertent dwertent commented Aug 13, 2024

This is no longer needed since arm64 support was added in tag 2.5

Fixes #305

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one suggestion would be to add a comment to the constants.go where the fabric images are set for the next person that updates them to check that they have ARM and AMD images

Signed-off-by: dwertent <[email protected]>
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff - thanks for adding the format command

@EnriqueL8 EnriqueL8 merged commit c05e5ee into hyperledger:main Aug 15, 2024
11 checks passed
@dwertent dwertent deleted the fix-fabric-amd branch August 16, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ARM64 support for Fabric images
2 participants