Ensure returning error from failed serialize of params

Signed-off-by: Peter Broadhurst <[email protected]>
hyperledger · Aug 4, 2024 · 7465a4a · 7465a4a
1 parent 14acc4f
commit 7465a4a
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/pkg/rpcbackend/wsbackend.go b/pkg/rpcbackend/wsbackend.go
@@ -343,12 +343,14 @@ func (rc *wsRPCClient) Subscriptions() []Subscription {
 }
 
 func (rc *wsRPCClient) sendRPC(ctx context.Context, reqID string, rpcReq *RPCRequest) *RPCError {
-	jsonInput, _ := json.Marshal(rpcReq)
-	log.L(ctx).Debugf("RPC[%s] --> %s", reqID, rpcReq.Method)
-	if logrus.IsLevelEnabled(logrus.TraceLevel) {
-		log.L(ctx).Tracef("RPC[%s] INPUT: %s", reqID, jsonInput)
+	jsonInput, err := json.Marshal(rpcReq)
+	if err == nil {
+		log.L(ctx).Debugf("RPC[%s] --> %s", reqID, rpcReq.Method)
+		if logrus.IsLevelEnabled(logrus.TraceLevel) {
+			log.L(ctx).Tracef("RPC[%s] INPUT: %s", reqID, jsonInput)
+		}
+		err = rc.client.Send(ctx, jsonInput)
 	}
-	err := rc.client.Send(ctx, jsonInput)
 	if err != nil {
 		rpcErr := NewRPCError(ctx, RPCCodeInternalError, signermsgs.MsgRPCRequestFailed, err)
 		log.L(ctx).Errorf("RPC[%s] <-- ERROR: %s", reqID, err)