Code

Implement EIP-712 Typed Data#51

Code

Merged

peterbroadhurst merged 30 commits intohyperledger:mainhyperledger/firefly-signer:mainfrom kaleido-io:typed_datakaleido-io/firefly-signer:typed_dataCopy head branch name to clipboardDec 3, 2023

+2,390-327

Commits

Commits on Oct 24, 2023

• First pass at adding typed data signing

  Show description for f580294
  awrichar

  committed
  f580294

  Copy full SHA for f580294

• Work to integrate EIP-712 code with ABI code (wip)

  Show description for 9e233c2
  

  peterbroadhurst

  authored and

  awrichar

  committed
  9e233c2

  Copy full SHA for 9e233c2

• Work through ABI->EIP-712 direction

  Show description for cc6a2c9
  

  peterbroadhurst

  authored and

  awrichar

  committed
  cc6a2c9

  Copy full SHA for cc6a2c9

• Significant additional refactoring of typed data V3 encoding

  Show description for 5e1d6d7
  

  peterbroadhurst

  authored and

  awrichar

  committed
  5e1d6d7

  Copy full SHA for 5e1d6d7

• More varation of scenarios

  Show description for f830806
  

  peterbroadhurst

  authored and

  awrichar

  committed
  f830806

  Copy full SHA for f830806

• Work through nil handling

  Show description for 74b550b
  

  peterbroadhurst

  authored and

  awrichar

  committed
  74b550b

  Copy full SHA for 74b550b

• Updated tests on ABI->TypedData interface

  Show description for 64b28ee
  

  peterbroadhurst

  authored and

  awrichar

  committed
  64b28ee

  Copy full SHA for 64b28ee

• Work through tests on encoding

  Show description for 9bd1df9
  

  peterbroadhurst

  authored and

  awrichar

  committed
  9bd1df9

  Copy full SHA for 9bd1df9

• Work through changes in signer interface

  Show description for e47d7f8
  

  peterbroadhurst

  authored and

  awrichar

  committed
  e47d7f8

  Copy full SHA for e47d7f8

• Merge tag 'v1.1.10' into HEAD

  Show description for 319a085
  awrichar

  committed
  319a085

  Copy full SHA for 319a085

• Merge remote-tracking branch 'origin/main' into HEAD

  Show description for 9700e14
  awrichar

  committed
  9700e14

  Copy full SHA for 9700e14

• Update linter

  Show description for 38bcfa6
  

  peterbroadhurst

  authored and

  awrichar

  committed
  38bcfa6

  Copy full SHA for 38bcfa6

Commits on Oct 25, 2023

• Provide individual parts of signature in Go utility

  Show description for a5db248
  peterbroadhurst

  committed
  a5db248

  Copy full SHA for a5db248

• Use simple structure for signature

  Show description for 1e59fbf
  peterbroadhurst

  committed
  1e59fbf

  Copy full SHA for 1e59fbf

• RLP signature too

  Show description for 1e82757
  peterbroadhurst

  committed
  1e82757

  Copy full SHA for 1e82757

Commits on Oct 31, 2023

• Fix docs on ABI structure

  Show description for fd5b5d1
  peterbroadhurst

  committed
  fd5b5d1

  Copy full SHA for fd5b5d1

• Avoid clashes

  Show description for 4060859
  peterbroadhurst

  committed
  4060859

  Copy full SHA for 4060859

• Work around odd issue

  Show description for f46dee6
  peterbroadhurst

  committed
  f46dee6

  Copy full SHA for f46dee6

Commits on Nov 1, 2023

• Add YAML support

  Show description for b1f5b39
  peterbroadhurst

  committed
  b1f5b39

  Copy full SHA for b1f5b39

• Update common

  Show description for be73017
  peterbroadhurst

  committed
  be73017

  Copy full SHA for be73017

Commits on Nov 2, 2023

• Do not assert version (confusion in TypeScript lib)

  Show description for 5f677b4
  peterbroadhurst

  committed
  5f677b4

  Copy full SHA for 5f677b4

Commits on Nov 9, 2023

• Correct double hashing issue

  Show description for df2f89e
  peterbroadhurst

  committed
  df2f89e

  Copy full SHA for df2f89e

• Update interface to split sign/sign-direct

  Show description for f06d0f7
  peterbroadhurst

  committed
  f06d0f7

  Copy full SHA for f06d0f7

• More fiddling with interface

  Show description for 187d458
  peterbroadhurst

  committed
  187d458

  Copy full SHA for 187d458

Commits on Nov 10, 2023

• Use Eth convention for signature

  Show description for ada360f
  peterbroadhurst

  committed
  ada360f

  Copy full SHA for ada360f

• Ensure documentation of field values

  Show description for 8108a60
  peterbroadhurst

  committed
  8108a60

  Copy full SHA for 8108a60

• Also document TypedData structure

  Show description for a302f6e
  peterbroadhurst

  committed
  a302f6e

  Copy full SHA for a302f6e

Commits on Nov 29, 2023

• Upgrade common and use consistent resty with common

  Show description for ba68367
  peterbroadhurst

  committed
  ba68367

  Copy full SHA for ba68367

• Pick up PR-112 from common

  Show description for f470ea1
  peterbroadhurst

  committed
  f470ea1

  Copy full SHA for f470ea1

Commits on Dec 3, 2023

• Remove duplicate message

  Show description for 04de049
  peterbroadhurst

  committed
  04de049

  Copy full SHA for 04de049