Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose API to directly call HashStruct from EIP-712 and M+N dims #68

Merged
merged 15 commits into from
Aug 8, 2024

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Jul 15, 2024

  • Allows use of the EIP-712 hashing algorithm for the data itself, without needing to also supply a domin.
  • Allows querying M and N dimensions of parsed Elementary Types
  • Fixes issue where we could have a Component array containing a nil entry on the case of extra parameters on input
  • Allows Recover functions to determine the original payload of the transactions, as well as the recovered signature
  • Allows raw signing key access, as well as secp256k1 curve-adapted access, to private key materials from keystorev3
  • Ensures errors from serializing inputs are returned

Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst peterbroadhurst changed the title Expose API to directly call HashStruct from EIP-712 Expose API to directly call HashStruct from EIP-712 and M+N dims Jul 17, 2024
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.62%. Comparing base (eb070cf) to head (1e4fa5d).
Report is 8 commits behind head on main.

Files Patch % Lines
pkg/keystorev3/walletfile.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #68      +/-   ##
===========================================
- Coverage   100.00%   99.62%   -0.38%     
===========================================
  Files           38       39       +1     
  Lines         3317     3474     +157     
===========================================
+ Hits          3317     3461     +144     
- Misses           0       13      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
@peterbroadhurst peterbroadhurst merged commit c144978 into main Aug 8, 2024
2 checks passed
@peterbroadhurst peterbroadhurst deleted the struct-hashing branch August 8, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants