remove .vscode settings (#66)

* remove .vscode settings Signed-off-by: Simon Davies <[email protected]> * additional changes and addressing feedback Signed-off-by: Simon Davies <[email protected]> * Update .devcontainer/Dockerfile Co-authored-by: Dan Chiarlone <[email protected]> Signed-off-by: Simon Davies <[email protected]> --------- Signed-off-by: Simon Davies <[email protected]> Co-authored-by: Dan Chiarlone <[email protected]>
hyperlight-dev · Nov 18, 2024 · 8cec8c0 · 8cec8c0
1 parent d771dea
commit 8cec8c0
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 78 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -59,5 +59,6 @@ RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y \
     && rustup target add x86_64-unknown-linux-gnu \
     && rustup target add x86_64-unknown-none      \
     && rustup target add x86_64-pc-windows-msvc   \
+    && rustup toolchain add nightly-x86_64-unknown-linux-gnu \
     && cargo install just
 
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -27,7 +27,12 @@
         "ms-vscode.cmake-tools",
         "rust-lang.rust-analyzer",
         "vadimcn.vscode-lldb"
-      ]
+      ],
+      "settings": {
+        "rust-analyzer.rustfmt.extraArgs": [
+          "+nightly" // required for rustfmt.toml which uses nightly features
+        ]
+      }
     }
   }
 }
diff --git a/.gitignore b/.gitignore
@@ -448,10 +448,6 @@ $RECYCLE.BIN/
 ## Visual Studio Code
 ##
 .vscode/*
-!.vscode/settings.json
-!.vscode/tasks.json
-!.vscode/launch.json
-!.vscode/extensions.json
 
 /downloads
 

diff --git a/.vscode/launch.json b/.vscode/launch.json
diff --git a/.vscode/settings.json b/.vscode/settings.json
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -38,6 +38,7 @@ All contributions come through pull requests. To submit a proposed change, we re
 #### Use work-in-progress PRs for early feedback
 
 A good way to communicate before investing too much time is to create a "Work-in-progress" PR and share it with your reviewers. The standard way of doing this is to add a "[WIP]" prefix in your PR's title and open the pull request as a draft.
+
 ### Developer Certificate of Origin: Signing your work
 
 #### Every commit needs to be signed
@@ -82,3 +83,7 @@ git push --force-with-lease <remote-name> <branch-name>
 ```
 
 *Credit: This doc was cribbed from Dapr.*
+
+### Rust Analyzer
+
+If you are using the [Rust Analyzer](https://rust-analyzer.github.io/manual.html) then you may need to set the configuration option `rust-analyzer.rustfmt.extraArgs` to `["+nightly"]` to ensure that formatting works correctly as this project has a [`rustfmt.toml`](./rustfmt.toml) file that uses nightly features.