Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the hyperlight proposal process #25

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

devigned
Copy link
Contributor

@devigned devigned commented Nov 6, 2024

This pull request establishes the Hyperlight Improvement Proposal process, or HIP. This process is roughly modeled after the Kubernetes Enhancement Proposal process, or KEP.

In this PR, I introduce the first proposal, which is the proposal for the proposal process. The documentation around the proposal process is provided as well as a template to help folks get started.

@devigned devigned added the kind/documentation Improvements or additions to documentation label Nov 6, 2024
Copy link
Contributor

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Might just be worth adding a section on what the process for submitting a HIP looks like.

(1) Write a HIP.
(2) Make a PR with a HIP.
(3) Address feedback on the HIP.

After that, if the HIP gets merged, is the idea that it was approved for implementation? I think we should clarify that in writing.

@devigned
Copy link
Contributor Author

devigned commented Nov 7, 2024

@danbugs, does this section cover it adequately (https://github.com/hyperlight-dev/hyperlight/pull/25/files#diff-38d0e78b0aa3c1b0361bb75e9c4ecbcf6d356dc01ac993966a562ce14252320eR8-R24). I'm guessing not since it wasn't clear. WDYT?

@danbugs
Copy link
Contributor

danbugs commented Nov 7, 2024

@danbugs, does this section cover it adequately (https://github.com/hyperlight-dev/hyperlight/pull/25/files#diff-38d0e78b0aa3c1b0361bb75e9c4ecbcf6d356dc01ac993966a562ce14252320eR8-R24). I'm guessing not since it wasn't clear. WDYT?

No, I just missed that on my review 😅 —LGTM!

@devigned devigned mentioned this pull request Nov 19, 2024
Copy link
Contributor

@dblnz dblnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devigned devigned merged commit c824f92 into hyperlight-dev:main Nov 20, 2024
8 checks passed
@devigned devigned deleted the hips branch November 20, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants