Fix 'download benchmark' workflow #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
fix_benchmark_artifact
branch
from
4c135f7 to
eb1d5a7
Compare
simongdavies
approved these changes
Nov 20, 2024
danbugs
reviewed
Nov 20, 2024
danbugs
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PRs are not able to compare performance to main branch, because downloading benchmarks from latest prerelease fails because the name of the artifact is incorrect. See https://github.com/hyperlight-dev/hyperlight/actions/runs/11925609379/job/33237994407#step:16:13 for an example error.
Here is an example of it now working https://github.com/hyperlight-dev/hyperlight/actions/runs/11928115786/job/33244575940?pr=74#step:16:12. Note that some will still fail, since we haven't published benchmarks with the new naming conventions yet (It will be done as part of prerelease when this PR is merged).
This pr also renames the matrix.hypervisor such that hyperv is used for windows, and mshv for linux