Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken realloc, rename and mark hlmalloc/hlfree/hlcalloc/hlrealloc unsafe #92

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Dec 2, 2024

First commit fixes the actual bug, the second commit is rename+docs+cleanup

@ludfjig ludfjig force-pushed the realloc branch 3 times, most recently from be313db to b3ff64c Compare December 3, 2024 00:17
@ludfjig ludfjig added the kind/bugfix Something isn't working label Dec 3, 2024
@ludfjig ludfjig marked this pull request as ready for review December 3, 2024 19:32
…was copied over but not updated to account for the new size.

Signed-off-by: Ludvig Liljenberg <[email protected]>
…ocumentations, and mark the functions unsafe

Signed-off-by: Ludvig Liljenberg <[email protected]>
Copy link
Contributor

@syntactically syntactically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good catches on switching to marking things unsafe and using the checked arithmetic ops.

@ludfjig ludfjig merged commit 65d06e6 into hyperlight-dev:main Dec 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants