add support for does not contain span filter operator (#175)

hypertrace · Sep 1, 2023 · bafa898 · bafa898
1 parent 27095cc
commit bafa898
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/...ice-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_filter.proto b/...ice-api/src/main/proto/org/hypertrace/span/processing/config/service/v1/span_filter.proto
@@ -54,6 +54,7 @@ enum RelationalOperator {
   RELATIONAL_OPERATOR_EQUALS = 1;
   RELATIONAL_OPERATOR_NOT_EQUALS = 2;
   RELATIONAL_OPERATOR_CONTAINS = 3;
+  RELATIONAL_OPERATOR_NOT_CONTAINS = 8;
   RELATIONAL_OPERATOR_STARTS_WITH = 4;
   RELATIONAL_OPERATOR_ENDS_WITH = 5;
   RELATIONAL_OPERATOR_REGEX_MATCH = 6;

diff --git a/...ng-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java b/...ng-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java
@@ -103,6 +103,8 @@ private boolean matches(String lhs, String rhs, RelationalOperator relationalOpe
       switch (relationalOperator) {
         case RELATIONAL_OPERATOR_CONTAINS:
           return lhs.contains(rhs);
+        case RELATIONAL_OPERATOR_NOT_CONTAINS:
+          return !lhs.contains(rhs);
         case RELATIONAL_OPERATOR_EQUALS:
           return lhs.equals(rhs);
         case RELATIONAL_OPERATOR_NOT_EQUALS:

diff --git a/...tils/src/test/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcherTest.java b/...tils/src/test/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcherTest.java
@@ -36,6 +36,17 @@ void testMatcher() {
             buildSpanFilterValue("names"),
             RelationalOperator.RELATIONAL_OPERATOR_CONTAINS));
 
+    assertFalse(
+        this.spanFilterMatcher.matches(
+            "name",
+            buildSpanFilterValue("nam"),
+            RelationalOperator.RELATIONAL_OPERATOR_NOT_CONTAINS));
+    assertTrue(
+        this.spanFilterMatcher.matches(
+            "name",
+            buildSpanFilterValue("names"),
+            RelationalOperator.RELATIONAL_OPERATOR_NOT_CONTAINS));
+
     assertTrue(
         this.spanFilterMatcher.matches(
             "name", buildSpanFilterValue("name"), RelationalOperator.RELATIONAL_OPERATOR_EQUALS));