Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Use shorter string for debug logs #187

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Use shorter string for debug logs #187

merged 2 commits into from
Dec 13, 2023

Conversation

mihirgt
Copy link
Contributor

@mihirgt mihirgt commented Dec 13, 2023

Use different method to to get shorter string for logging

@mihirgt mihirgt requested a review from a team as a code owner December 13, 2023 09:22
Copy link

github-actions bot commented Dec 13, 2023

Test Results

364 tests  ±0   364 ✔️ ±0   9s ⏱️ ±0s
  66 suites ±0       0 💤 ±0 
  66 files   ±0       0 ±0 

Results for commit b1b852c. ± Comparison against base commit 8f4dfb1.

This pull request removes 29 and adds 14 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [10] simple-selection
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [11] grouped-time-aggregation-with-group-limit-and-the-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [12] grouped-time-aggregation-with-group-limit-with-null-value-group
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [13] group-by-with-group-limit-and-rest
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [1] simple-aggregations
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [2] aggregations-with-groupby
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [3] time-aggregations-space-filtered
org.hypertrace.gateway.service.explore.ExploreServiceTest ‑ [4] group-by-with-offset
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8f4dfb1) 81.47% compared to head (b1b852c) 81.46%.

Files Patch % Lines
...pertrace/gateway/service/entity/EntityService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #187      +/-   ##
============================================
- Coverage     81.47%   81.46%   -0.02%     
  Complexity     1334     1334              
============================================
  Files           125      125              
  Lines          5971     5972       +1     
  Branches        490      490              
============================================
  Hits           4865     4865              
- Misses          864      865       +1     
  Partials        242      242              
Flag Coverage Δ
unit 81.46% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mihirgt mihirgt merged commit f280fa7 into main Dec 13, 2023
7 of 9 checks passed
@mihirgt mihirgt deleted the supress-logs branch December 13, 2023 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants