Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

fix | fix the context of EDS query while doing explore #189

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

aman-bansal
Copy link
Member

No description provided.

@aman-bansal aman-bansal requested a review from a team as a code owner December 22, 2023 08:01
Copy link

Test Results

366 tests  ±0   366 ✔️ ±0   9s ⏱️ ±0s
  67 suites ±0       0 💤 ±0 
  67 files   ±0       0 ±0 

Results for commit d0c2074. ± Comparison against base commit 235ff38.

This pull request removes 17 and adds 2 tests. Note that renamed tests count towards both.

      long: 60
      string: "PT1M"
      valueType: LONG
      valueType: STRING
    alias: "numCalls"
    columnName: "SERVICE.numCalls"
    value {
    }
  columnIdentifier {
…
org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [1] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: STRING
      string: "PT1M"
    }
  }
}
alias: "numCalls"

org.hypertrace.gateway.service.baseline.BaselineServiceImplTest ‑ [2] function: AVGRATE
arguments {
  columnIdentifier {
    columnName: "SERVICE.numCalls"
    alias: "numCalls"
  }
}
arguments {
  literal {
    value {
      valueType: LONG
      long: 60
    }
  }
}
alias: "numCalls"

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (235ff38) 82.55% compared to head (d0c2074) 82.56%.

Files Patch % Lines
...rters/EntityServiceAndGatewayServiceConverter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #189   +/-   ##
=========================================
  Coverage     82.55%   82.56%           
  Complexity     1367     1367           
=========================================
  Files           125      125           
  Lines          6066     6068    +2     
  Branches        501      501           
=========================================
+ Hits           5008     5010    +2     
  Misses          807      807           
  Partials        251      251           
Flag Coverage Δ
unit 82.56% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aman-bansal aman-bansal merged commit 03dbbc1 into main Dec 22, 2023
8 of 9 checks passed
@aman-bansal aman-bansal deleted the aman/fix_explore branch December 22, 2023 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants