Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starship cli #100

Merged
merged 6 commits into from
May 23, 2023
Merged

Starship cli #100

merged 6 commits into from
May 23, 2023

Conversation

Anmol1696
Copy link
Collaborator

@Anmol1696 Anmol1696 commented May 18, 2023

Part of #99

Commands supported:

  • start
  • stop

Just simple start stop via cli is now possible

@Anmol1696 Anmol1696 force-pushed the anmol/starship-cli branch from f09300d to 6758e76 Compare May 21, 2023 04:24
@Anmol1696
Copy link
Collaborator Author

Kube context is not passed properly to the helm actionConfig structs.
Helm go sdk needs to be used better for this to work. Would take longer.

@Anmol1696
Copy link
Collaborator Author

Actually this did work. Back to working on this as the standard way for building out the client.

@Anmol1696 Anmol1696 marked this pull request as ready for review May 23, 2023 07:26
@Anmol1696 Anmol1696 merged commit 99526e4 into main May 23, 2023
@Anmol1696 Anmol1696 deleted the anmol/starship-cli branch May 23, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant