Minor stuttering in animations after 6a90b50 commit

[goggi]

Already reported ? *

• I have searched the existing open and closed issues.

Regression?

Definitely a regression - something broke after update (requires bisect)

System Info and Hyprland Version

System/Version info

Hyprland 0.46.0 built from branch  at commit b9f110ef8726fcba2b4ee69856027731e73003a5  ().
Date: 2025-01-06
Tag: v0.46.0, commits: 
built against:
 aquamarine 0.6.0
 hyprlang 0.6.0
 hyprutils 0.3.3
 hyprcursor 0.1.11
 hyprgraphics 0.1.1


no flags were set


System Information:
System name: Linux
Node name: gza
Release: 6.6.69
Version: #1-NixOS SMP PREEMPT_DYNAMIC Thu Jan  2 09:32:11 UTC 2025


GPU information: 
2f:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Navi 23 [Radeon RX 6600/6600 XT/6600M] [1002:73ff] (rev c1) (prog-if 00 [VGA controller])


os-release: ANSI_COLOR="0;38;2;126;186;228"
BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="25.05.20250104.8f3e1f8"
CPE_NAME="cpe:/o:nixos:nixos:25.05"
DEFAULT_HOSTNAME=nixos
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
ID_LIKE=""
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 25.05 (Warbler)"
SUPPORT_URL="https://nixos.org/community.html"
VARIANT=""
VARIANT_ID=""
VENDOR_NAME=NixOS
VENDOR_URL="https://nixos.org/"
VERSION="25.05 (Warbler)"
VERSION_CODENAME=warbler
VERSION_ID="25.05"

Description

After #8966 was merged I started getting minor animation stuttering if the workspace had a Firefox based browser on it. There is also a drop in around 10 fps when switching from a workspace that contains the ff based browser.

So the issue is directly linked to the following commit: 6a90b50

If I remove the comments for:

        // if (current.buffer->buffer->isSynchronous())
             // dropCurrentBuffer();

it works like expected again.

Its been discussed briefly in the PR: #8966

How to reproduce

1. If I have the browser (zen) on workspace 1 and then move to workspace 2 that contains vscode, the animation shutters.
2. If I move back and forward fast between the workspace then i get around 10 fps drop.
3. This does not happen if I move between workspace 2 (vscode) and workspace 3 (chrome)

Attach not paste

• I understand that all text files must be attached, and not pasted directly. If not respected, this issue will likely get closed as spam

Checklist of files to include below

• Hyprland config - hyprctl systeminfo -c (always include)
• Crash report (always include in case of crash)
• Video (always include in case of a visual bug)
• Logs (might contain useful info such as errors)

Additional info & File uploads

The video files that illustrate the issue are way to big, but it its really needed, then I'll figure out how to add it.

[vaxerski]

@UjinT34 (regressor)

The problem here is that I believe the release we were sending is correct. After updating the texture, if it is synchronous, we properly release it.

Is there perhaps a difference in WAYLAND_DEBUG outputs on hyprland with the second release un-commented and say, sway?

[frkli1965]

Thought I'd give activating the two lines of code and rebuilding a try.

Lo and behold, all the Firefox and MPV related weirdness I described under issue #8930, have miraculously disappeared as a result.

Thanks goggi, much appreciated, well spotted btw!

Regarding Sway, I've experienced very similar problems with the latest sway-git but not with the last official release (version 1.10-1) direct from the Arch repository, if that helps at all.

Would even dare suggest that the stuttering is considerably more acute under sway-git than it is on Hyprland right now.