-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(clang-format): directly do the clang-format instead of error #8955
base: main
Are you sure you want to change the base?
Conversation
Lmk if u prefer executing the push via the command instead |
I really don't like this. I don't like bots committing to the repo in general. |
Eh ok :( |
How about bot suggesting commits via review? |
eh? @vaxerski |
that sounds fine, depending on how it's done. If it just attaches a patch that's okay, as long as its not spammy. |
See the review. Then you'd have an option to just press commit Then one of them will be author and another will be co author of that commit |
what if there are 20 files needing 10 patches each? Massive spam. |
alright, preview: littleblack111#1 (comment) |
yep, that looks good. Two things, firstly, the message needs to be nicer and more bot-like:
Then, put the patch in a spoiler like this
|
thanks! Much better. |
Describe your PR, what does it fix/add?
as title suggestes, atm clang-format will just give error and we have to manually fix it, this PR makes it so it automatically does it for us
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
if you dont mind the github actions bot spamming commits and growing in the contribution graph ig
Is it ready for merging, or does it need work?
tested in another repo