Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cb clipboard manager #798

Merged
merged 1 commit into from
Oct 10, 2024
Merged

add cb clipboard manager #798

merged 1 commit into from
Oct 10, 2024

Conversation

Slackadays
Copy link
Contributor

@Slackadays Slackadays commented Oct 9, 2024

  • add cb clipboard manager: cb is a terminal oriented option that has tons of eye candy plus some features other clipboard managers don't have like actually unlimited history and more (oh, and being 100% C++ too :).
  • fix "Github" capitalization: GitHub is GitHub, not Github, can't believe nobody else caught this now everything is "Github"

@fufexan
Copy link
Member

fufexan commented Oct 9, 2024

Can you split the commits? One for formatting, one for adding cb.

@vaxerski
Copy link
Member

vaxerski commented Oct 9, 2024

I don't like writing GitHub like that cuz the other hub doesn't capitalize like that + it kinda looks wonky imo

@Slackadays Slackadays force-pushed the main branch 2 times, most recently from 7c26970 to 81ee2fa Compare October 9, 2024 10:51
@Slackadays
Copy link
Contributor Author

Slackadays commented Oct 9, 2024

@fufexan fixed, 1 commit for cb, 1 commit to make everything "Github" instead

@fufexan
Copy link
Member

fufexan commented Oct 9, 2024

I don't like writing GitHub like that cuz the other hub doesn't capitalize like that + it kinda looks wonky imo

one of the bruh moments of all time. it's the name of a service, we shall use it as is

@Slackadays
Copy link
Contributor Author

awaiting your final decision, @vaxerski

@vaxerski
Copy link
Member

whatever

@Slackadays
Copy link
Contributor Author

my opinion: either Github or GitHub is going to be better than the random mix that's in the wiki right now

@Slackadays
Copy link
Contributor Author

@fufexan should I just get rid of the capitalization commit?

@fufexan
Copy link
Member

fufexan commented Oct 10, 2024

The second one yeah.

@Slackadays
Copy link
Contributor Author

The second one yeah.

Done

@fufexan fufexan changed the title add cb clipboard manager and fix "Github" capitalization add cb clipboard manager Oct 10, 2024
@fufexan fufexan merged commit e9b017b into hyprwm:main Oct 10, 2024
@m-hugo
Copy link

m-hugo commented Dec 16, 2024

cb isn't compatible with hyprland, why did you add it?

@m-hugo
Copy link

m-hugo commented Dec 16, 2024

with default cb and hyprland behavior the focused window flickers every second because a window is spawned

@m-hugo
Copy link

m-hugo commented Dec 16, 2024

see Slackadays/Clipboard#171

@Slackadays
Copy link
Contributor Author

It is compatible but the Wayland clipboard protocol is a piece of garbaj and so cb is awaiting a fix to either implement the Special Snowflake™ clipboard protocol or don't check it in the background

@m-hugo
Copy link

m-hugo commented Dec 16, 2024

so it's not compatible
@fufexan @vaxerski spending more time nitpicking formatting than thinking if a random clipboard should be the first wiki pick is very bad maintainership

@Slackadays
Copy link
Contributor Author

It is compatible by definition because it follows the Wayland clipboard protocol to a T

@m-hugo
Copy link

m-hugo commented Dec 16, 2024

it follows the Wayland clipboard protocol to a T

there is no "Wayland clipboard protocol" and there's no part of the wayland protocols that says you should open a window every 2s

@m-hugo
Copy link

m-hugo commented Dec 16, 2024

and if you really want to advertise your shit here at least add a warning that it flickers every second with the default config and a sane config to the wiki

@Slackadays
Copy link
Contributor Author

Someone is BIG MAD

@m-hugo
Copy link

m-hugo commented Dec 16, 2024

yes

@fufexan
Copy link
Member

fufexan commented Dec 17, 2024

@fufexan @vaxerski spending more time nitpicking formatting than thinking if a random clipboard should be the first wiki pick is very bad maintainership

Thanks for letting us know. Next time clipboards come up I'll ping you to discuss.

As for cb, is there any workaround or do we remove it from the wiki?

@m-hugo
Copy link

m-hugo commented Dec 17, 2024

Thanks for letting us know. Next time clipboards come up I'll ping you to discuss.

not really a clipboard-specific request, maybe just don't merge unreviewed pull request for unreviewed software no hyprland user ever used without testing them yourself

As for cb, is there any workaround or do we remove it from the wiki?

just remove it

@Slackadays
Copy link
Contributor Author

There is a temporary fix I can add so it doesn't need to be removed, @fufexan what do you think?

@fufexan
Copy link
Member

fufexan commented Dec 17, 2024

Sure, PR please.

@Slackadays
Copy link
Contributor Author

The temp fix is actually in cb, I will just disable background clipboard updating and call it a day

@m-hugo
Copy link

m-hugo commented Dec 20, 2024

which will make it wildly inferior to every other clipboard on the list

@fufexan
Copy link
Member

fufexan commented Dec 21, 2024

Correct. I'll update the wiki to warn about that.

@Slackadays
Copy link
Contributor Author

I'll push the update with the quick fix tomorrow

@kociap
Copy link
Contributor

kociap commented Jan 3, 2025

The version available in AUR renders the entire desktop unusable because all windows are repositioned every ~2 seconds. Does not work with wl-paste --watch either. Please remove from the wiki as this software is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants