Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

547 hotfix mightee #560

Merged
merged 12 commits into from
Mar 26, 2024
Merged

547 hotfix mightee #560

merged 12 commits into from
Mar 26, 2024

Conversation

Lukas113
Copy link
Collaborator

closes #547

This PR addresses the following:

  • Reading correct cols from .fits files of MIGHTEE and GLEAM
  • Implemented a correct and generalized version to read sky-sources from .fits file. The previous version had the following issues:
    • Didn't consider unit-scaling & checks
    • Didn't allow to read frequencies
    • Was not generalized
  • Introduced helper-classes with tests to address these issues

@Lukas113 Lukas113 requested a review from mpluess March 22, 2024 14:19
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 94.07666% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 66.86%. Comparing base (9e2b77c) to head (ef59de9).

Files Patch % Lines
karabo/simulation/sky_model.py 94.03% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   65.96%   66.86%   +0.89%     
==========================================
  Files          49       49              
  Lines        4792     4970     +178     
==========================================
+ Hits         3161     3323     +162     
- Misses       1631     1647      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mpluess mpluess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell

@Lukas113 Lukas113 merged commit 934e135 into main Mar 26, 2024
6 checks passed
@Lukas113 Lukas113 deleted the 547-hotfix-mightee branch March 26, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix MIGHTEE Sky
2 participants