-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish_L2 / RID LUT Manager #385
Conversation
end2end is looking good complains about the added header keyword in all fits files |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
==========================================
- Coverage 77.10% 75.97% -1.13%
==========================================
Files 66 68 +2
Lines 6906 7069 +163
==========================================
+ Hits 5325 5371 +46
- Misses 1581 1698 +117 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this depend on #382 as that would need to be merged first if so?
Looks ok to me few small queries. What the find.py thing for?
Co-authored-by: Shane Maloney <[email protected]>
the find script is a helper CLI tool that scans the given fits folder for files with certain properties. it is not used within the pipeline but will help us to find dedicated fits files for reprocessing/review ... not many properties implemented so fare but some. Level, version, product_type, OBT_BEG/END ... |
class ScienceProduct(GenericProduct, EnergyChannelsMixin, FitsHeaderMixin): | ||
"""Generic science data product class composed of control and data.""" | ||
def __init__(self, *, service_type, service_subtype, ssid, control, data, **kwargs): | ||
"""Create a generic science data product composed of control and data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samaloney here the L0 files getting the mixing
prod.add_additional_header_keywords(additional_header_keywords) | ||
return prod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samaloney here a list of keywords is added
there is also a prod.add_additional_header_keyword() if you would like to add a single one
but most likely as the product is created as last step you have to store the keyword in a list during processing
additional_header_keywords.append(("TRIG_SCA", factor, 'used trigger descale factor')) | ||
triggers, triggers_var = unscale_triggers( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samaloney here i keep track of one additional keyword
Preparations for publishing l2 products
also
use of a singelton RidLutManager that pulls in data from the platform api and persiets it into a local csv file