Flexible way to fill DATAMAX/MIN BUNIT EXPOSURE in FITS header keywords #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
==========================================
+ Coverage 75.75% 75.82% +0.06%
==========================================
Files 68 68
Lines 7119 7250 +131
==========================================
+ Hits 5393 5497 +104
- Misses 1726 1753 +27 ☔ View full report in Codecov by Sentry. |
samaloney
approved these changes
May 15, 2024
| @@ -109,6 +130,19 @@ def __init__(self, *, service_type, service_subtype, ssid, control, data, | |||
| self.name = 'flareflag' | |||
| self.level = 'L1' | |||
|
|
|||
| @property | |||
| def dmin(self): | |||
| return min([self.data['loc_y'].min(), self.data['loc_z'].min()]) | |||
There was a problem hiding this comment.
Is value or to_value() not needed here as below?
| @@ -75,6 +75,21 @@ def __init__(self, *, service_type, service_subtype, ssid, control, | |||
| self.name = 'xray-vis' | |||
| self.level = 'L1' | |||
|
|
|||
| @property | |||
| def dmin(self): | |||
There was a problem hiding this comment.
Yea this might be tricky as they are complex numbers
samaloney
reviewed
Oct 7, 2024
Merged
|
Ok normal test look good now but in the E2E tests at L1530 and L2008 don't seem related and are unexpected at least at first look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so far only products with "count" data fill in this keywords in a usefull way. with this more flexible way of generating it should be much better to fill this keywords for deticated products