Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dequote if_fullname if_shortname #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bortok
Copy link

@bortok bortok commented Nov 17, 2021

Hi,

When generating a topology with eOS devices, I noticed links between two eOS boxes would always get duplicated. The issue is caused by eOS returning LLDP neighbor's interface name in double-quotes. It should be safe to always dequote interface names as part of if_fullname and if_shortname functions. The fix was tested in on a simple 4-node spine-leaf topology.

Here is an example of show lldp neighbor details output from eOS:

Interface Ethernet1 detected 1 LLDP neighbors:

  Neighbor 2a19.9ed4.b06c/"Ethernet1", age 28 seconds
  Discovered 1:00:27 ago; Last changed 1:00:27 ago
  - Chassis ID type: MAC address (4)
    Chassis ID     : 2a19.9ed4.b06c
  - Port ID type: Interface name(5)
    Port ID     : "Ethernet1"
  - Time To Live: 120 seconds
  - System Name: "pod1"
  - System Capabilities : Bridge, Router
    Enabled Capabilities: Bridge, Router
  - Management Address Subtype: IPv4
    Management Address        : 10.0.254.254
    Interface Number Subtype  : ifIndex (2)
    Interface Number          : 5000000
    OID String                :
  - IEEE802.1 Port VLAN ID: 0
  - IEEE802.1/IEEE802.3 Link Aggregation
    Link Aggregation Status: Capable, Disabled (0x01)
    Port ID                : 0
  - IEEE802.3 Maximum Frame Size: 9236 bytes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant