Delete migrated file 400_contributeAndCallback.js #177
+120
−709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #177 +/- ##
===========================================
- Coverage 84.87% 84.50% -0.37%
===========================================
Files 35 35
Lines 1084 1084
Branches 221 221
===========================================
- Hits 920 916 -4
- Misses 164 168 +4 ☔ View full report in Codecov by Sentry. |
…ture/400_contribute-and-callback-cleaning
Base automatically changed from
feature/400_contribute-and-callback-migration
to
develop
January 10, 2025 15:14
zguesmi
commented
Jan 10, 2025
| it('viewDeal', async function () { | ||
| const { dealId } = await createDeal(); | ||
| const deal = await iexecPoco.viewDeal(dealId); | ||
| console.log('🚀 ~ deal sponsor:', deal.sponsor); |
There was a problem hiding this comment.
Suggested change
| console.log('🚀 ~ deal sponsor:', deal.sponsor); |
zguesmi
commented
Jan 10, 2025
| console.log('score:', await iexecPoco.viewScore(worker1.address)); | ||
| }); | ||
|
|
||
| // viewScore(address _worker) |
There was a problem hiding this comment.
Suggested change
| // viewScore(address _worker) |
zguesmi
commented
Jan 10, 2025
| expect(contribution.resultSeal.length).to.equal(66); | ||
| expect(contribution.enclaveChallenge).to.equal(AddressZero); | ||
| expect(contribution.weight).to.equal(1); | ||
| console.log('score:', await iexecPoco.viewScore(worker1.address)); |
There was a problem hiding this comment.
Suggested change
| console.log('score:', await iexecPoco.viewScore(worker1.address)); |
| @@ -1,18 +1,21 @@ | |||
| // SPDX-FileCopyrightText: 2020-2024 IEXEC BLOCKCHAIN TECH <[email protected]> | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2020-2024 IEXEC BLOCKCHAIN TECH <[email protected]> | |
| // SPDX-FileCopyrightText: 2020-2025 IEXEC BLOCKCHAIN TECH <[email protected]> |
gfournieriExec
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.