Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sunset Jenkins pipeline #178

Merged
merged 15 commits into from
Jan 14, 2025
Merged

Sunset Jenkins pipeline #178

merged 15 commits into from
Jan 14, 2025

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Jan 9, 2025

No description provided.

@zguesmi zguesmi self-assigned this Jan 9, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Le-Caignec
Le-Caignec reviewed Jan 9, 2025
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (0d55ac8) to head (75f0084).
Report is 16 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #178   +/-   ##
========================================
  Coverage    84.50%   84.50%           
========================================
  Files           35       35           
  Lines         1084     1084           
  Branches       221      221           
========================================
  Hits           916      916           
  Misses         168      168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Le-Caignec
Le-Caignec approved these changes Jan 10, 2025
View reviewed changes
Copy link

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏎️

@zguesmi zguesmi marked this pull request as ready for review January 10, 2025 16:36
gfournieriExec
gfournieriExec approved these changes Jan 14, 2025
View reviewed changes
.github/workflows/main.yml
@@ -10,31 +10,48 @@ on:
- v5

jobs:
# Note: changing the name of the job disables Slither checks with the error:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding !

@zguesmi zguesmi requested a review from jeremyjams January 14, 2025 09:32
jeremyjams
jeremyjams approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@jeremyjams jeremyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you!

@zguesmi zguesmi merged commit 1470213 into develop Jan 14, 2025
4 checks passed
@zguesmi zguesmi deleted the feature/jenkins-ci-sunset branch January 14, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Le-Caignec Le-Caignec Le-Caignec approved these changes

@gfournieriExec gfournieriExec gfournieriExec approved these changes

@jeremyjams jeremyjams jeremyjams approved these changes

Assignees

@zguesmi zguesmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zguesmi @jeremyjams @Le-Caignec @gfournieriExec