-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Java 17 #728
base: develop
Are you sure you want to change the base?
Upgrade to Java 17 #728
Conversation
build.gradle
Outdated
@@ -52,6 +58,8 @@ dependencyManagement { | |||
} | |||
|
|||
dependencies { | |||
implementation platform("org.springframework.boot:spring-boot-dependencies:${springBootVersion}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary when the spring boot plugin is declared in the plugins
block ?
This bom should have been added to iexec-core-library
and iexec-task-library
(with removal of explicit versions on dependencies)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 63df4cb
Dockerfile
Outdated
RUN test -n "$jar" | ||
|
||
RUN apt-get update \ | ||
RUN test -n "$jar" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want to follow this suggestion here, at least today.
There can be good reasons to keep several RUN statements in the Dockerfile.
I propose to keep this for a later time and to revert the change to stay consistent across all projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 5946dcd
Quality Gate passedIssues Measures |
No description provided.