Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java 17 #728

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Upgrade to Java 17 #728

wants to merge 13 commits into from

Conversation

Natchica
Copy link
Contributor

@Natchica Natchica commented Jan 2, 2025

No description provided.

@Natchica Natchica self-assigned this Jan 2, 2025
@Natchica Natchica marked this pull request as ready for review January 2, 2025 16:40
@Natchica Natchica changed the title Update dependencies and project compatibility to Java 17 Upgrade to Java 17 Jan 2, 2025
build.gradle Outdated
@@ -52,6 +58,8 @@ dependencyManagement {
}

dependencies {
implementation platform("org.springframework.boot:spring-boot-dependencies:${springBootVersion}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary when the spring boot plugin is declared in the plugins block ?
This bom should have been added to iexec-core-library and iexec-task-library (with removal of explicit versions on dependencies)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 63df4cb

Dockerfile Outdated
RUN test -n "$jar"

RUN apt-get update \
RUN test -n "$jar" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want to follow this suggestion here, at least today.
There can be good reasons to keep several RUN statements in the Dockerfile.
I propose to keep this for a later time and to revert the change to stay consistent across all projects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in 5946dcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants