Clarify documentation for updateVoucherTypeDescription to indicate in…

…tended feature per Halborn audit
iExecBlockchainComputing · Jan 3, 2025 · 52180cb · 52180cb
1 parent 8675176
commit 52180cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/contracts/VoucherHub.sol b/contracts/VoucherHub.sol
@@ -107,6 +107,7 @@ contract VoucherHub is
      * This function only updates the duration for newly minted vouchers and not the existing ones to provide
      * guarantees regarding the expiration of vouchers. When a voucher is delivered, its credits should not expire
      * before the original expiration date.
+     * This is not a bug as mentioned in audit of Halborn (HAL-01) but an intended feature.
      */
     function updateVoucherTypeDescription(
         uint256 id,

diff --git a/docs/VoucherHub.md b/docs/VoucherHub.md
@@ -60,6 +60,7 @@ function updateVoucherTypeDescription(uint256 id, string description) external
 This function only updates the duration for newly minted vouchers and not the existing ones to provide
 guarantees regarding the expiration of vouchers. When a voucher is delivered, its credits should not expire
 before the original expiration date.
+This is not a bug as mentioned in audit of Halborn (HAL-01) but an intended feature.
 
 ### updateVoucherTypeDuration