Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hardhat deploy #15

Merged
merged 20 commits into from
Apr 29, 2024
Merged

Use hardhat deploy #15

merged 20 commits into from
Apr 29, 2024

Conversation

zguesmi
Copy link
Member

@zguesmi zguesmi commented Apr 22, 2024 •
edited
Loading 

$ hardhat deploy

Generating typings for: 42 artifacts in dir: typechain-types for target: ethers-v6
Successfully generated 154 typings!
Compiled 41 Solidity files successfully (evm target: paris).
UpgradeableBeacon: 0xe7f1725E7734CE288F8367e1Bb143E90bb3F0512
Voucher: 0x5FbDB2315678afecb367f032d93F642f64180aa3
VoucherHub: 0xCf7Ed3AccA5a467e9e704C703E8D87F634fB0Fc9

@zguesmi zguesmi self-assigned this Apr 22, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f272526) to head (4e4b07d).

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          155       155           
  Branches        21        21           
=========================================
  Hits           155       155

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi zguesmi marked this pull request as ready for review April 25, 2024 14:34
jeremyjams
jeremyjams reviewed Apr 25, 2024
View reviewed changes
deploy/0_deploy.ts Outdated Show resolved Hide resolved
deploy/0_deploy.ts Outdated Show resolved Hide resolved
deploy/0_deploy.ts Outdated Show resolved Hide resolved
@zguesmi @jeremyjams
Update deploy/0_deploy.ts
a9261ce 
Co-authored-by: Jérémy James Toussaint <[email protected]>
@zguesmi zguesmi requested a review from jeremyjams April 26, 2024 08:42
jeremyjams
jeremyjams reviewed Apr 26, 2024
View reviewed changes
deploy/deploy.ts Outdated Show resolved Hide resolved
deploy/deploy.ts Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@zguesmi zguesmi requested a review from jeremyjams April 26, 2024 13:31
jeremyjams
jeremyjams reviewed Apr 26, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@zguesmi zguesmi requested a review from jeremyjams April 29, 2024 09:51
jeremyjams
jeremyjams reviewed Apr 29, 2024
View reviewed changes
deploy/deploy.ts Outdated Show resolved Hide resolved
jeremyjams
jeremyjams approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@jeremyjams jeremyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thanks :)

gfournieriExec
gfournieriExec approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@zguesmi zguesmi merged commit 965a71f into develop Apr 29, 2024
4 checks passed
@zguesmi zguesmi deleted the feature/integration-tests branch April 29, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfournieriExec gfournieriExec gfournieriExec approved these changes

@jeremyjams jeremyjams jeremyjams approved these changes

Assignees

@zguesmi zguesmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zguesmi @jeremyjams @gfournieriExec