Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/patch token decimals into voucher hub #50

Merged
merged 13 commits into from
Jan 3, 2025

Conversation

Le-Caignec
Copy link

@Le-Caignec Le-Caignec commented Dec 23, 2024

  • Add commentary regarding the Halborn audit report, mentioning informational feedback about the updateVoucherTypeDuration function.
  • Override the decimals function of ERC-20 to set the token's decimal precision to 9, aligning with RLC standards.

@Le-Caignec Le-Caignec changed the title Feature/patch token decimal voucher hub Feature/patch token decimals into voucher hub Dec 23, 2024
@Le-Caignec Le-Caignec self-assigned this Dec 23, 2024
@Le-Caignec Le-Caignec requested a review from a team December 23, 2024 09:17
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (145178d) to head (c9ee780).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #50   +/-   ##
========================================
  Coverage    99.29%   99.30%           
========================================
  Files            4        4           
  Lines          284      286    +2     
  Branches        53       53           
========================================
+ Hits           282      284    +2     
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll let the team re-check

@Le-Caignec Le-Caignec requested a review from a team January 2, 2025 10:33
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
contracts/NonTransferableERC20Upgradeable.sol Outdated Show resolved Hide resolved
contracts/VoucherHub.sol Outdated Show resolved Hide resolved
test/VoucherHub.test.ts Outdated Show resolved Hide resolved
test/VoucherHub.test.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
contracts/NonTransferableERC20Upgradeable.sol Outdated Show resolved Hide resolved
@Le-Caignec Le-Caignec merged commit 224fe6c into develop Jan 3, 2025
5 checks passed
@Le-Caignec Le-Caignec deleted the feature/patch-token-decimal-voucherHub branch January 3, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants