Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/better handling env variables #55

Merged
merged 17 commits into from
Jan 6, 2025

Conversation

Le-Caignec
Copy link

@Le-Caignec Le-Caignec commented Jan 3, 2025

  • Add .env.template for better understanding/summary of the available env variable on the repo
  • Add Zod as validator for .env variables. (⚠️ import .env variables without validator is a bad smell in TS)

@Le-Caignec Le-Caignec self-assigned this Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (224fe6c) to head (d116865).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #55   +/-   ##
========================================
  Coverage    99.30%   99.30%           
========================================
  Files            4        4           
  Lines          286      286           
  Branches        53       53           
========================================
  Hits           284      284           
  Misses           2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Le-Caignec Le-Caignec requested a review from a team January 3, 2025 10:52
@gfournieriExec
Copy link
Contributor

Don't forget to update changelog :)

@gfournieriExec gfournieriExec marked this pull request as ready for review January 3, 2025 11:25
.env.template Outdated Show resolved Hide resolved
.env.template Outdated Show resolved Hide resolved
.env.template Outdated Show resolved Hide resolved
.env.template Outdated Show resolved Hide resolved
env.ts Outdated Show resolved Hide resolved
env.ts Outdated Show resolved Hide resolved
env.ts Outdated Show resolved Hide resolved
env.ts Outdated Show resolved Hide resolved
deploy/deploy.ts Outdated Show resolved Hide resolved
env.ts Outdated Show resolved Hide resolved
.env.template Outdated Show resolved Hide resolved
.env.template Outdated Show resolved Hide resolved
env.ts Outdated Show resolved Hide resolved
env.ts Outdated Show resolved Hide resolved
env.ts Outdated Show resolved Hide resolved
@Le-Caignec Le-Caignec requested a review from zguesmi January 6, 2025 08:53
.env.template Outdated Show resolved Hide resolved
deploy/deploy.ts Outdated Show resolved Hide resolved
deploy/deploy.ts Show resolved Hide resolved
.env.template Outdated Show resolved Hide resolved
deploy/deploy.ts Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
Copy link
Member

@jeremyjams jeremyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thank you!

Copy link
Contributor

@gfournieriExec gfournieriExec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Copy link
Member

@zguesmi zguesmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat !
Thanks.

@Le-Caignec Le-Caignec merged commit dad18ca into develop Jan 6, 2025
5 checks passed
@Le-Caignec Le-Caignec deleted the feature/better-handling-env-variables branch January 6, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants