ResendEmailVerificationView requires queryset #309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#44 (comment) ## Problems * When POSTed `email` to ResendemailVerificationView, we get `'ResendEmailVerificationView' should either include a queryset attribute, or override the get_queryset() method.` error. * When the email POSTed does not exist in the system, `EmailAddress.DoesNotExist` exception is raised. ## Solution * `ResendEmailVerificationView` requires `queryset` attribute since it extends `CreateAPIView` * `ResendEmailVerificationView` requires exception handling in cases email does not exist in the database. `EmailAddress.objects.get()` raises exception, instead of returning `False`.
|
I see the changes are fixed, closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44 (comment)
Problems
emailto ResendemailVerificationView, we get'ResendEmailVerificationView' should either include a queryset attribute, or override the get_queryset() method.error.EmailAddress.DoesNotExistexception is raised.Solution
ResendEmailVerificationViewrequiresquerysetattribute since it extendsCreateAPIViewResendEmailVerificationViewusesfilter().first()to avoid exception in cases email does not exist in the database.EmailAddress.objects.get()raises exception, instead of returningFalse.