replace Cache by Lru cache #2451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftoromanoff
force-pushed
the
lruCache
branch
3 times, most recently
from
217ac00 to
f5e0a65
Compare
ftoromanoff
force-pushed
the
lruCache
branch
3 times, most recently
from
3611195 to
755b70e
Compare
ftoromanoff
force-pushed
the
lruCache
branch
2 times, most recently
from
70d6cf4 to
a615509
Compare
|
@ftoromanoff does it solve #869 ? |
ftoromanoff
force-pushed
the
lruCache
branch
7 times, most recently
from
5ceb4a3 to
0abce48
Compare
ftoromanoff
force-pushed
the
lruCache
branch
2 times, most recently
from
119976e to
51d9192
Compare
I can't say. Is there a way to test it ? |
jailln
requested review from
AnthonyGlt
and removed request for
jailln and
AnthonyGlt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace our own itowns.cache per the lru-cache package.
Currently we use 1 cache for each Layer + 1 for Style and another one for tile. Should we change that ?
I also arbitrary fixed the max size of each cache to 500. Maybe this should be discuse, depending of the type of cache ?
Other question what should I do with export const CACHE_POLICIES, I currently kept the 'Cache.js' file just for this.