Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clean and update of the Source/ folder #969

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

zarov
Copy link
Contributor

@zarov zarov commented Dec 14, 2018

Part of #968

I also deprecated heightMapWidth in profit of width which is the real name of the parameter in the creation of as WMS url. I don't know if I could also add the height property ? So we could have something like:

this.width = source.width || source.height || 256;
this.height = source.height || source.width || 256;

Copy link
Contributor

@gchoqueux gchoqueux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@zarov zarov force-pushed the update-source-docs branch from e3da2a1 to 9f7406e Compare December 14, 2018 10:33
@zarov zarov merged commit ca920c6 into iTowns:master Dec 14, 2018
@zarov zarov deleted the update-source-docs branch December 14, 2018 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants