Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests running multiple times #261

Merged
merged 21 commits into from
Oct 22, 2024
Merged

Conversation

ben-polinsky
Copy link
Collaborator

@ben-polinsky ben-polinsky commented Oct 21, 2024

Fix a few causes of possible flakey integration tests, specifically brower-authorization on mac os.

  • Browser and oidc-signin-tool integration tests were running three times: once for typescript, once for cjs build files, and one for esm build files.
  • Clean up some promise handling around waiting for the popup close event.
  • Reduce lengthy timeouts which have not proven helpful

@ben-polinsky ben-polinsky changed the title create pop up login button dynamically; resolve some promises in-tandem Integration tests running multiple times Oct 22, 2024
@ben-polinsky ben-polinsky merged commit 4fc67fe into main Oct 22, 2024
13 checks passed
@ben-polinsky ben-polinsky deleted the mac-integration-test-fixes branch October 22, 2024 20:43
@ben-polinsky ben-polinsky mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants