V2 Widget push #76
Merged
V2 Widget push #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Pulled Util functions out of code for large widget. Created custom hook for usePagedNamedVersionLoader. Started converting old class components to functional components.
roluk
suggested changes
Feb 7, 2024
...nged-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareSelectModal.tsx
Outdated
Show resolved
Hide resolved
mattbjordan
reviewed
Feb 7, 2024
packages/changed-elements-react/src/widgets/comparisonJobWidget/hooks/useNamedVersionLoader.tsx
Outdated
Show resolved
Hide resolved
…t/hooks/useNamedVersionLoader.tsx Co-authored-by: Matt Jordan <[email protected]>
mattbjordan
reviewed
Feb 8, 2024
...nged-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareSelectModal.tsx
Outdated
Show resolved
Hide resolved
…t/components/VersionCompareSelectModal.tsx Co-authored-by: Matt Jordan <[email protected]>
diegopinate
reviewed
Feb 8, 2024
diegopinate
reviewed
Feb 8, 2024
packages/changed-elements-react/src/widgets/comparisonJobWidget/hooks/useNamedVersionLoader.tsx
Outdated
Show resolved
Hide resolved
diegopinate
reviewed
Feb 8, 2024
packages/changed-elements-react/src/widgets/comparisonJobWidget/hooks/useNamedVersionLoader.tsx
Outdated
Show resolved
Hide resolved
roluk
suggested changes
Feb 9, 2024
...nged-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareSelectModal.tsx
Outdated
Show resolved
Hide resolved
packages/changed-elements-react/src/widgets/FeedbackButton.scss
Outdated
Show resolved
Hide resolved
…ed up VersionCompareSelectModal.tsx
roluk
suggested changes
Feb 12, 2024
...nged-elements-react/src/widgets/comparisonJobWidget/components/VersionCompareSelectModal.tsx
Outdated
Show resolved
Hide resolved
roluk
approved these changes
Feb 12, 2024
diegopinate
approved these changes
Feb 12, 2024
mattbjordan
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This widget uses v3 of the itwins API. Leveraging comparison jobs to streamline the vc service.
